D27468: Don't double delete CommentsModel

2020-02-18 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R304:5c7ee50bf900: Dont double delete CommentsModel (authored by davidedmundson). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27468?vs=75866=75886 REVISION DETAIL

D27468: Don't double delete CommentsModel

2020-02-18 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Quite right. Looks like some leftovers from before that caching was added, shippit :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D27468

D27468: Don't double delete CommentsModel

2020-02-17 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY CommentsModel instances are owned by the engine. They are fetched through a getter with a cache, so