D27502: Create ConfigView an unmanaged ConfigWidget

2020-03-23 Thread Benjamin Port
This revision was automatically updated to reflect the committed changes. Closed by commit R246:12d1e200f081: Create ConfigView an unmanaged ConfigWidget (authored by bport). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=77269=78296 REVISION DETAIL

D27502: Create ConfigView an unmanaged ConfigWidget

2020-03-16 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

2020-03-09 Thread Benjamin Port
bport updated this revision to Diff 77269. bport added a comment. rename check to skip and add missing negation for default REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76517=77269 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-27 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > settings.cpp:62 > > -bool Settings::setCheckUppercase(bool check) > +void Settings::setSkipUppercase(bool check) > { Rename the parameter to skip as well

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-26 Thread Benjamin Port
bport updated this revision to Diff 76517. bport added a comment. rename check uppercase to skip uppercase REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76384=76517 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED FILES

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > settings.cpp:62 > > -bool Settings::setCheckUppercase(bool check) > +void Settings::setCheckUppercase(bool check) > { Please rename it to "skip

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Benjamin Port
bport updated this revision to Diff 76384. bport added a comment. Rework, not expose anymore settings and loader but expose a new settings class REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=75997=76384 REVISION DETAIL

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-25 Thread Benjamin Port
bport added inline comments. INLINE COMMENTS > ervin wrote in settings.cpp:109 > This is an odd bit of logic, isn't it? Yes indeed, but what we want is to save false if checked and true if not checked. I moved the logic there in order to work with kconfigxt and with current implementation >

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-24 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > loader.h:6 > */ > -#ifndef SONNET_LOADER_P_H > -#define SONNET_LOADER_P_H > +#ifndef SONNET_LOADER_H > +#define SONNET_LOADER_H What's the reason for loader

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-19 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-19 Thread Benjamin Port
bport added a dependent revision: D27503: [KCM Spellchecking] port to KPropertySkeletonItem. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-19 Thread Benjamin Port
bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY - Allow to manage controller externally - Compatible (for checkbox)