D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
This revision was automatically updated to reflect the committed changes. Closed by commit R39:444bbb37926f: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27533?vs=77041&id=77180 REVISION DETAIL https://phabricator.kde.org/D27533 AFFECTED FILES src/document/katedocument.cpp src/document/katedocument.h src/include/ktexteditor/markinterface.h src/search/katesearchbar.cpp src/view/kateviewhelpers.cpp To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
cullmann added a comment. Thanks for working on this. Badly scaled stuff is a real eyesore... REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
kossebau retitled this revision from "[Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks" to "Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks". kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
kossebau added a comment. Having thought some more about the KDevelop cases, their pixmap preprocessing really should be replaced by proper custom icons, so the currently proposed MarkInterfaceV2 should be fine also for KDevelop. Thus going to land this post 5.68 tagging then as is. Thanks everyone for review :) REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
kossebau updated this revision to Diff 77041. kossebau added a comment. Do proper static_cast into QMetaType enum REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27533?vs=76127&id=77041 BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 AFFECTED FILES src/document/katedocument.cpp src/document/katedocument.h src/include/ktexteditor/markinterface.h src/search/katesearchbar.cpp src/view/kateviewhelpers.cpp To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
D27533: [Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks
kossebau retitled this revision from "[WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks" to "[Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks". REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars
