D27616: [UrlHandler] optimise the code and less if nesting

apol added inline comments. INLINE COMMENTS > ahmadsamir wrote in urlhandler.cpp:55 > I could be wrong, but this is exactly equivalent to the original code, i.e. > it won't reach this unless helpcenter is empty and it's not a kde app... and > I actually wanted to ask about this bit from the

D27616: [UrlHandler] optimise the code and less if nesting

ahmadsamir added a comment. I created D27615 first; then this one on top of it (optimising the code in a separate commit). INLINE COMMENTS > apol wrote in urlhandler.cpp:55 > won't this recurse forever? I could be wrong, but this is exactly equivalent

D27616: [UrlHandler] optimise the code and less if nesting

apol added a comment. LGTM otherwise INLINE COMMENTS > urlhandler.cpp:55 > +// not a KDE application > +QDesktopServices::openUrl(u); > } won't this recurse forever? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir,

D27616: [UrlHandler] optimise the code and less if nesting

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Depends on D27615 TEST PLAN make && ctest REPOSITORY R273 KGuiAddons