D27632: Implement UString operator= to make gcc happy
This revision was automatically updated to reflect the committed changes. Closed by commit R314:e637e721e40e: Implement UString operator= to make gcc happy (authored by aacid). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27632?vs=76323&id=79911 REVISION DETAIL https://phabricator.kde.org/D27632 AFFECTED FILES src/kjs/ustring.h To: aacid, porten Cc: porten, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D27632: Implement UString operator= to make gcc happy
porten accepted this revision. porten added a comment. This revision is now accepted and ready to land. I now see that the member is kept as a RefPtr. Unlike the previously used raw pointer I now understand why the the assignment operator can be implemented that simple. For completness: the gcc switch that triggers the warning is -Wdeprecated-copy REPOSITORY R314 KJs BRANCH master REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid, porten Cc: porten, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D27632: Implement UString operator= to make gcc happy
porten added a comment. On first sight I don't get how the class' memory management works these days. Before commenting on the patch I have to refresh my knowledge. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27632: Implement UString operator= to make gcc happy
aacid added a subscriber: porten. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D27632: Implement UString operator= to make gcc happy
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY otherwise complains that there's a copy constructor but not an assignment operator REPOSITORY R314 KJs BRANCH master REVISION DETAIL https://phabricator.kde.org/D27632 AFFECTED FILES src/kjs/ustring.h To: aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns