D27633: Port to KPluginLoader

2020-06-13 Thread Pino Toscano
pino added a comment. In D27633#619369 , @aacid wrote: > In D27633#619365 , @aacid wrote: > > > I think this broke

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. In D27633#619369 , @aacid wrote: > In D27633#619365 , @aacid wrote: > > > I think this broke

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. In D27633#619365 , @aacid wrote: > I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ┬┐KAccountsDPlugin now requires parameters to the constructor

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ┬┐KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE? @nicolasfella can you please look at it?

D27633: Port to KPluginLoader

2020-02-27 Thread Luca Beltrame
lbeltrame added a comment. This currently causes a compile error: /home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78: error: call of overloaded 'create(AccountsDaemon*, )' is ambiguous REPOSITORY R155 KAccounts

D27633: Port to KPluginLoader

2020-02-25 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > kaccountsdplugin.cpp:24 > > -KAccountsDPlugin::KAccountsDPlugin(QObject *parent) > +KAccountsDPlugin::KAccountsDPlugin(QObject *parent, const QVariantList& args) > : QObject(parent) This caused a compiler warning to show up - pushed a quick

D27633: Port to KPluginLoader

2020-02-24 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by nicolasfella). REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27633?vs=76326=76335 REVISION DETAIL

D27633: Port to KPluginLoader

2020-02-24 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH kpluginloader REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks, apol

D27633: Port to KPluginLoader

2020-02-24 Thread Nicolas Fella
nicolasfella added reviewers: leinir, Frameworks. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks