D27633: Port to KPluginLoader

2020-06-13 Thread Pino Toscano
pino added a comment.


  In D27633#619369 , @aacid wrote:
  
  > In D27633#619365 , @aacid wrote:
  >
  > > I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  > >
  > > @nicolasfella can you please look at it?
  >
  >
  > On top of that that's a BIC change, you can't do BIC changes on KF5 repos, 
so revert?
  
  
  Even if it is not a Framework, this is still a BIC change without an SONAME 
bump; @nicolasfella what about bumping `KACCOUNTS_SOVERSION` in the top-level 
CMakeLists.txt to `2` to reflect that?

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: pino, aacid, lbeltrame


D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment.


  In D27633#619369 , @aacid wrote:
  
  > In D27633#619365 , @aacid wrote:
  >
  > > I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  > >
  > > @nicolasfella can you please look at it?
  >
  >
  > On top of that that's a BIC change, you can't do BIC changes on KF5 repos, 
so revert?
  
  
  kaccount-integrations is not a KF5 repo ^_^

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame


D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment.


  In D27633#619365 , @aacid wrote:
  
  > I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  >
  > @nicolasfella can you please look at it?
  
  
  On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so 
revert?

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame


D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment.


  I think this broke 
https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console
 guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus 
not a valid Q_INTERFACE?
  
  @nicolasfella can you please look at it?

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: aacid, lbeltrame


D27633: Port to KPluginLoader

2020-02-27 Thread Luca Beltrame
lbeltrame added a comment.


  This currently causes a compile error:
  

/home/abuild/rpmbuild/BUILD/kaccounts-integration-20.03.70git.20200225T132248~74e770c/src/daemon/daemon.cpp:62:78:
 error: call of overloaded 'create(AccountsDaemon*, )' is ambiguous

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol
Cc: lbeltrame


D27633: Port to KPluginLoader

2020-02-25 Thread Dan Leinir Turthra Jensen
leinir added inline comments.

INLINE COMMENTS

> kaccountsdplugin.cpp:24
>  
> -KAccountsDPlugin::KAccountsDPlugin(QObject *parent)
> +KAccountsDPlugin::KAccountsDPlugin(QObject *parent, const QVariantList& args)
>  : QObject(parent)

This caused a compiler warning to show up - pushed a quick fix already so don't 
worry about it, but thought i'd mention it for completion's sake :) 
https://commits.kde.org/kaccounts-integration/74e770cc9398d9802f9d0fef652cb5b6da29a74d

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol


D27633: Port to KPluginLoader

2020-02-24 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes.
Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by 
nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27633?vs=76326=76335

REVISION DETAIL
  https://phabricator.kde.org/D27633

AFFECTED FILES
  src/daemon/daemon.cpp
  src/lib/kaccountsdplugin.cpp
  src/lib/kaccountsdplugin.h

To: nicolasfella, bshah, leinir, #frameworks, apol


D27633: Port to KPluginLoader

2020-02-24 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  kpluginloader

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol


D27633: Port to KPluginLoader

2020-02-24 Thread Nicolas Fella
nicolasfella added reviewers: leinir, Frameworks.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks