D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a08449a9a2cb: templates: Convert license statements to 
SPDX headers (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27640?vs=76679=76680

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 76679.
kossebau added a comment.


  Update license keys to what KAboutLicense currently supports

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27640?vs=76343=76679

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D27640#619817 , @cordlandwehr 
wrote:
  
  > My only question is, how is the X-KDE-PluginInfo-License value is 
evaluated? Are we free to write any value? Or do we have to extend some 
mechanism? I would be great to also use SPDX identifiers there!
  
  
  From what I can tell, Plasma itself currently ignores the license info, e.g. 
there is no display of About data for plasmoids or wallpaper plugins (sadly, 
IMHO, but no resources to fix myself).
  
  In general X-KDE-PluginInfo+* is feed to KPluginMetaData, which just holds 
the raw string. The string itself is evaluated e,g,in KAboutPluginDialog via 
KAboutLicense::byKeyword(), the only place I know about currently (besides 
deprecated KAboutData::fromPluginMetaData, which does the same 
KAboutLicense::byKeyword).
  
  KAboutLicense itself once was already extended to support keywords (see D6672 
), but needs update to latest SPDX 
identifiers,

INLINE COMMENTS

> cordlandwehr wrote in metadata.desktop:96
> does this work with our PluginInfo mechanism? actually, I did not yet look 
> into the SPDX license handling in desktop files or any other tooling for 
> outbound licenses for libraries, plugins or applications; same question for 
> the same changes below in the desktop files

Hmpf, this is outdated version, forgot to append to commit before arc diff.
Should be "LGPLv21+" as I had found later that KAboutLicense still only 
supports the meanwhile deprecated spdx key variants.
Will update next.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Looks good to me and I agree that it is a good idea to consistently license 
everything as LGPL-2.1-or-later.
  My only question is, how is the X-KDE-PluginInfo-License value is evaluated? 
Are we free to write any value? Or do we have to extend some mechanism? I would 
be great to also use SPDX identifiers there!

INLINE COMMENTS

> metadata.desktop:96
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
> +X-KDE-PluginInfo-License=LGPL-2.1-or-later
>  X-KDE-PluginInfo-EnabledByDefault=true

does this work with our PluginInfo mechanism? actually, I did not yet look into 
the SPDX license handling in desktop files or any other tooling for outbound 
licenses for libraries, plugins or applications; same question for the same 
changes below in the desktop files

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27640

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, cordlandwehr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also consistently use LGPL-2.1-or-later as default license

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns