D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:94015abda31b: Fix scrolling on the EntryDetails page 
(authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27696?vs=76532=76535

REVISION DETAIL
  https://phabricator.kde.org/D27696

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread hexchain
hexchain accepted this revision.
hexchain added a comment.
This revision is now accepted and ready to land.


  Looks good on khotnewstuff-dialog. Thanks!

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27696

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
leinir added reviewers: ngraham, Frameworks, Plasma, hexchain.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27696

To: leinir, ngraham, #frameworks, #plasma, hexchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27696: Fix scrolling on the EntryDetails page

2020-02-27 Thread Dan Leinir Turthra Jensen
leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  For ScrollablePage to be able to scroll, the scrollable content must
  be the last Item on the page.
  
  BUG:418191

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-scrolling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27696

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns