D27705: Use QStringLiteral
nicolasfella marked an inline comment as done. REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27705 To: nicolasfella, #frameworks, bshah, leinir, apol Cc: apol
D27705: Use QStringLiteral
This revision was automatically updated to reflect the committed changes. Closed by commit R155:be294dcc69e7: Use QStringLiteral (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27705?vs=76566=76610#toc REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76566=76610 REVISION DETAIL https://phabricator.kde.org/D27705 AFFECTED FILES src/kcm/accounts.cpp src/lib/createaccountjob.cpp src/lib/getcredentialsjob.cpp src/lib/uipluginsmanager.cpp To: nicolasfella, #frameworks, bshah, leinir, apol Cc: apol
D27705: Use QStringLiteral
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
if you want to have this, it could make sense to enforce it from cmake.
INLINE COMMENTS
> createaccount.cpp:195
> base.append(authData.method());
> -base.append("/");
> +base.append(QStringLiteral("/"));
> base.append(authData.mechanism());
Use QLatin1Char here.
REPOSITORY
R155 KAccounts Integration
BRANCH
arcpatch-D27705
REVISION DETAIL
https://phabricator.kde.org/D27705
To: nicolasfella, #frameworks, bshah, leinir, apol
Cc: apol
D27705: Use QStringLiteral
nicolasfella updated this revision to Diff 76566. nicolasfella added a comment. Remove unintended change REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76565=76566 BRANCH arcpatch-D27705 REVISION DETAIL https://phabricator.kde.org/D27705 AFFECTED FILES src/jobs/createaccount.cpp src/kcm/accounts.cpp src/lib/getcredentialsjob.cpp src/lib/uipluginsmanager.cpp To: nicolasfella, #frameworks, bshah, leinir
D27705: Use QStringLiteral
nicolasfella updated this revision to Diff 76565. nicolasfella added a comment. Remove unintended changes REPOSITORY R155 KAccounts Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27705?vs=76563=76565 BRANCH arcpatch-D27705 REVISION DETAIL https://phabricator.kde.org/D27705 AFFECTED FILES CMakeLists.txt src/jobs/createaccount.cpp src/kcm/accounts.cpp src/lib/getcredentialsjob.cpp src/lib/uipluginsmanager.cpp To: nicolasfella, #frameworks, bshah, leinir
D27705: Use QStringLiteral
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, bshah, leinir. nicolasfella requested review of this revision. REVISION SUMMARY Don't use naked strings TEST PLAN builds REPOSITORY R155 KAccounts Integration BRANCH qsl REVISION DETAIL https://phabricator.kde.org/D27705 AFFECTED FILES CMakeLists.txt src/jobs/createaccount.cpp src/kcm/accounts.cpp src/lib/getcredentialsjob.cpp src/lib/uipluginsmanager.cpp To: nicolasfella, #frameworks, bshah, leinir
