D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-05-23 Thread Méven Car 
meven added a comment.


  I believe this causes https://bugs.kde.org/show_bug.cgi?id=419434
  It causes similar issue with dolphin and KFileWidget
  
  This is not a correct behavior.
  It prevents file treeview to show files within folders with no subfolders.
  The bug has a proposed patch :
  https://bugsfiles.kde.org/attachment.cgi?id=128272
  
  I think this needs to be reverted or at least reworked.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-29 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread Raphael Rosch 
rrosch accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread David Faure 
dfaure added a reviewer: rrosch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27731

To: dfaure, apol, ahmadsamir, meven, rrosch
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27731: Improve KDirModel to avoid showing '+' if there are no subdirs

2020-02-28 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: apol, ahmadsamir, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  We either have the information at hand (in populated dirs)
  or we query the filesystem (in non-populated dirs).

TEST PLAN
  Tested by Raphael Rosch in D25315 

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27731

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: dfaure, apol, ahmadsamir, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns