This revision was automatically updated to reflect the committed changes.
Closed by commit R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob
run when not required (authored by bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27766?vs=76734&id=
astippich accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D27766
To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,
cbla
bruns added a dependent revision: D27767: [ModifiedFileIndexer] Correct time
checks for new files.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D27766
To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,
cblack, fbampal
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in modifiedfileindexer.cpp:118
> This check is redundant now, we here only when `cTimeChanged` is true.
I saw it in other patch, i does not need change.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kd
anthonyfieroni added inline comments.
INLINE COMMENTS
> modifiedfileindexer.cpp:118
> if (tr.hasDocument(job.document().id())) {
> if (cTimeChanged) {
> tr.replaceDocument(job.document(), XAttrTerms | DocumentTime
> | FileNameTerms | DocumentUrl);
This che
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
In case only the mtime has changed (i.e. only contents), only the times
and t
