D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-03 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:55a43cf13514: [ModifiedFileIndexer] Omit BasicIndexingJob 
run when not required (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27766?vs=76734&id=76891

REVISION DETAIL
  https://phabricator.kde.org/D27766

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-03 Thread Alexander Stippich
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham, astippich
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Stefan Brüns
bruns added a dependent revision: D27767: [ModifiedFileIndexer] Correct time 
checks for new files.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in modifiedfileindexer.cpp:118
> This check is redundant now, we here only when `cTimeChanged` is true.

I saw it in other patch, i does not need change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Anthony Fieroni
anthonyfieroni added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:118
>  if (tr.hasDocument(job.document().id())) {
>  if (cTimeChanged) {
>  tr.replaceDocument(job.document(), XAttrTerms | DocumentTime 
> | FileNameTerms | DocumentUrl);

This check is redundant now, we here only when `cTimeChanged` is true.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams


D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case only the mtime has changed (i.e. only contents), only the times
  and the content indexing flag have to be updated in the DB. The times
  are already available from the fileinfo, so no need to create a
  BasicIndexingJob.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27766

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams