D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0bbe57ef7f33: [ModifiedFileIndexer] Correct time checks 
for new files (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27767?vs=76744=76892

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Alexander Stippich 
astippich added a comment.


  I would like to request a clear answer for https://phabricator.kde.org/D25517 
once again

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-03 Thread Alexander Stippich 
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham, astippich
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns edited the summary of this revision.
bruns added a dependency: D27766: [ModifiedFileIndexer] Omit BasicIndexingJob 
run when not required.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns updated this revision to Diff 76744.
bruns added a comment.


  const

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27767?vs=76735=76744

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:74
> +bool cTimeChanged;
> +bool isKnownFile = tr.hasDocument(fileId);
> +if (isKnownFile) {

const?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case baloo has just started, a new and immediately modified file can
  end up in the ModifiedFileIndexer. In this case, the timestamps default
  to 0. As a 0 timestamp also occasionally appears e.g. for files from
  archives (tar, zip ...) these would be treated as unchanged and not be
  added to the index.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams