D27848: Remove the panel tooltip icon

2020-04-06 Thread Nathaniel Graham
ngraham added a comment. Fixed in 7aaee715aff2a3fadf950f686a8be5e0d49c3297 and did it the correct way in 1f0cf38dbf2eb7de2b7fe09ef82bbb281a296a68

D27848: Remove the panel tooltip icon

2020-04-06 Thread David Redondo
davidre added a comment. In D27848#643045 , @ngraham wrote: > See the parent task. > > This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these t

D27848: Remove the panel tooltip icon

2020-04-06 Thread Kai Uwe Broulik
broulik added a comment. > For all panel widgets which are all governed by a single place: `plasma-desktop/desktoppackage/contents/applet/CompactApplet.qml` Imho an unacceptable behavior break for a Frameworks component. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D27848: Remove the panel tooltip icon

2020-04-06 Thread Nathaniel Graham
ngraham added a comment. See the parent task. This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these tooltips, because they're either redundant or inconsistent with the icon that you're hov

D27848: Remove the panel tooltip icon

2020-04-06 Thread David Redondo
davidre added a comment. I think this was done at the wrong level. If we don't want icons in the systray then the way would be to net set the property in the systray and not ignore the property in the generic component but keep the property for api stability purposes. Now we have a componen

D27848: Remove the panel tooltip icon

2020-04-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:863ec93adec6: Remove the panel tooltip icon (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27848?vs=76971&id=79368 REVISI

D27848: Remove the panel tooltip icon

2020-03-04 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove, apol Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr

D27848: Remove the panel tooltip icon

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. If the #plasma people accept, this would need to wait until Frameworks 5.70 to land or else rolling release distros will lose icons in half their tooltips, but not the rest. REPOSITORY R242 Plasma Framework (Library) BRANC

D27848: Remove the panel tooltip icon

2020-03-04 Thread Nathaniel Graham
ngraham retitled this revision from "Remove the tooltip icon" to "Remove the panel tooltip icon". REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove