D27851: Add rss icons in action

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by 
ognarb).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27851?vs=76976&id=76979

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb, #vdg, #breeze, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D27851: Add rss icons in action

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D27851#622296 , @cblack wrote:
  
  > SVG-wise, optimization here seems suboptimal. There's excess elements that 
could be removed.
  >
  > Visually, the icon looks like the RSS icon, which is about all you need out 
of an RSS icon.
  >
  > I do believe we need at least 16px and 22px for monochromatic actions, 
though.
  
  
  The main reason we optimize is to make the code readable, not to make it as 
small as possible. The current version is fine.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carson Black]

cblack added a comment.


  SVG-wise, optimization here seems suboptimal. There's excess elements that 
could be removed.
  
  Visually, the icon looks like the RSS icon, which is about all you need out 
of an RSS icon.
  
  I do believe we need at least 16px and 22px for monochromatic actions, though.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze
Cc: cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carson Black]

cblack edited reviewers, added: VDG, Breeze; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: ndavis.
ognarb added a project: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

TEST PLAN
  Soon

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns