D27926: [breeze-icons] Add flameshot tray icons

2020-03-09 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Derp, silly me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis
ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis
ndavis added a comment.


  It's a systray icon, so it doesn't need to have a 16px version

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Ariel AxionL
axionl marked an inline comment as done.
axionl added a comment.


  In D27926#624240 , @ngraham wrote:
  
  > Nice!
  >
  > Do you think you could also make 16px versions?
  
  
  Sorry, maybe not. The 16px space is too small to get the correct angle to 
convert 1px thick strokes to paths on Inkscape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Nathaniel Graham
ngraham added a comment.


  Nice!
  
  Do you think you could also make 16px versions?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Ariel AxionL
axionl updated this revision to Diff 77223.
axionl added a comment.


  Update flameshot tray icon.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27926?vs=77197=77223

REVISION DETAIL
  https://phabricator.kde.org/D27926

AFFECTED FILES
  icons-dark/status/22/flameshot-tray.svg
  icons/status/22/flameshot-tray.svg

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, this will be nice to have once the issue identified in my comment is 
resolved.

INLINE COMMENTS

> flameshot-tray.svg:2
> + xmlns="http://www.w3.org/2000/svg;>
> + stroke-width=".26458333">
> +

Hardcoded colors alert! :)

You need to embed the stylesheet and make each path use it. Follow the pattern 
in other monochrome breeze icons, and see how to do that at 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Embedding_stylesheets_in_SVGs

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns


D27926: [breeze-icons] Add flameshot tray icons

2020-03-07 Thread Ariel AxionL
axionl retitled this revision from "Add flameshot tray icons" to 
"[breeze-icons] Add flameshot tray icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns