D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment. And btw., thanks a lot for taking care! The vimode for sure has more need for love, if you have time ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann, kwrite-devel

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:736844969d2b: [VIM Mode] Add g g commands (authored by gikari, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77355&id=

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment. I think, one issue is, that and don't work that way in the test framework. I reformulated the test with \down and \up and moved the asserts to verifies. This works for me, will push this, please take a look if that is ok for you, too. REPOSITORY R39 KTextEdi

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann, kwrite-devel,

D27928: [VIM Mode] Add g g commands

2020-03-11 Thread Mikhail Zolotukhin
gikari added a comment. Yes, my case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sar

D27928: [VIM Mode] Add g g commands

2020-03-11 Thread Christoph Cullmann
cullmann added a comment. I will try to take a look as soon as I have time, if nobody else is faster. Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gika

D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin
gikari added a comment. I added a unit test, but I do not know why it is failing. Actually I do not know if I've added it correctly at all. Help is very necsasary. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: dhaumann,

D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 77355. gikari added a comment. - Add unit-test REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77199&id=77355 BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL https://phabricator.kde.or

D27928: [VIM Mode] Add g g commands

2020-03-10 Thread Dominik Haumann
dhaumann added a comment. The intimidating one :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, c

D27928: [VIM Mode] Add g g commands

2020-03-09 Thread Mikhail Zolotukhin
gikari added a comment. I am not sure where I should add it. Is it supposed to be a new pair of `bug418486` `.h/.cpp` files? Or should the test reside inside `keys.cpp` in big intimidating 500 line wide `MappingTest` function? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricat

D27928: [VIM Mode] Add g g commands

2020-03-09 Thread Dominik Haumann
dhaumann added a comment. I like the patch, but please add a unit test before we commit this. See https://github.com/KDE/ktexteditor/tree/master/autotests/src/vimode Could you add one? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate,

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin
gikari edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaum

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin
gikari added reviewers: Kate, Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauman

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin
gikari created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gikari requested review of this revision. REVISION SUMMARY Add twin commands for `gj` and `gk` for usage with standard arrow keys. BUG: 418486 TEST PLAN