trmdi marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
trmdi updated this revision to Diff 77349.
trmdi added a comment.
Move fileItem back to the local scope
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27951?vs=77329&id=77349
BRANCH
add-dndToMove (branched from master)
REVISION DETAIL
https://phabricator.
meven requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
meven added inline comments.
INLINE COMMENTS
> dropjob.cpp:150
> Qt::KeyboardModifiers m_keyboardModifiers;
> +KFileItemList m_fileItems;
> +KFileItemListProperties m_itemProps;
I think you don't need a member here, a local variable should suffice.
REPOSITORY
R241 KIO
REVISION D
trmdi updated this revision to Diff 77329.
trmdi added a comment.
- Check possible actions in determineDropAction
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27951?vs=77298&id=77329
BRANCH
add-dndToMove (branched from master)
REVISION DETAIL
https://ph
trmdi planned changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
meven added a comment.
And BTW I reported a QT bug relating to the keyboard modifiers not working as
expected a while back, making this feature more appealing :
https://bugreports.qt.io/browse/QTBUG-79919
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi,
meven added a comment.
I added the bug wish https://bugs.kde.org/show_bug.cgi?id=224257 althoug it
will require a KCM setting to be feature complete.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure
Cc: meven, kde-frameworks-devel, LeGast
meven edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
You need to only apply this logic for files. Try dragging a URL from a web
browser to the desktop; now that fails because it can't delete the URL (the
fact that "Move" is even a
trmdi edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
trmdi added reviewers: ngraham, dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D27951
To: trmdi, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
trmdi created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trmdi requested review of this revision.
REVISION SUMMARY
Lots of users request to be able to change the default behavior of the
drag&drop action to MoveAction.
TEST PLAN
With dn
13 matches
Mail list logo
