D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Tranter Madi 
trmdi updated this revision to Diff 77350.
trmdi added a comment.


  Address meven's comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77349=77350

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Méven Car 
meven added a comment.


  This does not include the workspace-option kcm setting.
  So I would title this "Allow users to change dropAction to MoveAction through 
a dndToMove kdeglobal setting"

INLINE COMMENTS

> dropjob.cpp:288
>  }
> +if (!m_destUrl.matches(url.adjusted(QUrl::RemoveFilename), 
> QUrl::StripTrailingSlash)) {
> +equalDestination = false;

You could add `equalDestination &&` here to save further checking.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27951: Allow users to change dropAction to MoveAction through workspace kcm

2020-03-10 Thread Tranter Madi 
trmdi retitled this revision from "Allow users to change dropAction to 
MoveAction through workspace-option kcm" to "Allow users to change dropAction 
to MoveAction through workspace kcm".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns