D27985: Include s_kcrashErrorMessage in our traces

2020-03-18 Thread Kai Uwe Broulik
broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985 To

D27985: Include s_kcrashErrorMessage in our traces

2020-03-15 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77452&id=77676 REVISION DETAIL

D27985: Include s_kcrashErrorMessage in our traces

2020-03-12 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM for when the kcrash diff is ready. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D27985 To: apol, #frameworks, sitter Cc: plasma-devel, Orag

D27985: Include s_kcrashErrorMessage in our traces

2020-03-11 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 77452. apol added a comment. Include a usage in the test app, adapt to changes in kcrash REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77424&id=77452 BRANCH master REVISION DETAIL https://phabricator.kde.or

D27985: Include s_kcrashErrorMessage in our traces

2020-03-11 Thread Harald Sitter
sitter added a comment. Probably should also get added to one of the parser tests to make sure it doesn't fall on the face. Talking about parser, I feel like this might benefit from highlighting somehow, currently it's very squished in with the random stuff in the header. That'll make i

D27985: Include s_kcrashErrorMessage in our traces

2020-03-11 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY CCBUG: 375913 TEST PLAN Called `kill -SIGSEGV plasma-discover` and got to see the string I pa