D27989: Add a new set of barcode size functions

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27989#670659 , @vkrause wrote: > There's two remaining users in everything covered by lxr, the Plasma clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM (which now depends on a sufficiently

D27989: Add a new set of barcode size functions

2020-05-14 Thread Volker Krause
vkrause added a comment. In D27989#670416 , @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start,

D27989: Add a new set of barcode size functions

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau added a comment. > minimumSize() becomes deprecated by this, the deprecation macros will > follow once the current users have been adjusted. IMHO you should add the macros from the start, otherwise it will be only forgotten later, as there is no mechanism to remind you. And

D27989: Add a new set of barcode size functions

2020-03-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:838f886c380f: Add a new set of barcode size functions (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27989?vs=77441=77647 REVISION DETAIL

D27989: Add a new set of barcode size functions

2020-03-11 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27989 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27989: Add a new set of barcode size functions

2020-03-11 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking