D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-21 Thread David Faure
dfaure closed this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28016 To: dfaure, zzag, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-19 Thread Vlad Zahorodnii
zzag added a comment. Maybe it would be worth to send an email to wm-spec-list proposing to deprecate LAUNCHED_BY, but on the other hand fixing X11 stuff in any way is like beating a dead horse. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't 100% agree that "it doesn't seem used". It's used in KStartupInfoData::Private::to_text() which affects what gets written out over the wire to everyone else.

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-13 Thread Vlad Zahorodnii
zzag added a comment. Do you know why LAUNCHED_BY was added? The spec [1] has no a single word about its potential use cases. [1] https://specifications.freedesktop.org/startup-notification-spec/startup-notification-latest.txt REPOSITORY R278 KWindowSystem REVISION DETAIL

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-13 Thread Kai Uwe Broulik
broulik added a comment. Anything WId also probably won't work on Wayland, so +1 REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28016 To: dfaure, zzag, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28016: KWindowSystem: deprecate KStartupInfoData::launchedBy, unused

2020-03-13 Thread David Faure
dfaure created this revision. dfaure added reviewers: zzag, broulik, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KRun bothers with a WId in many places just to end up calling