D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:f4a6bf060b0c: [breeze-icons] fix shadow in some user (applets/128) icons (authored by rocka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow_2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-fra

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Rocket Aaron
rocka updated this revision to Diff 77886. rocka added a comment. Try to fix icon display in inkscape REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28094?vs=77814&id=77886 BRANCH fix-user-icon-shadow_2 (branched from master) REVISION DETAIL http

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. BTW, you can use this website to search for text in the code of all KDE software: https://lxr.kde.org/search REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblac

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. In D28094#629427 , @rocka wrote: > Weird, I edited them in Inkscape … > > Aren't those icons used as default avatar in user manager? Nope. Those were actually kept in the user-manager repo until they were remov

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Rocket Aaron
rocka added a comment. Weird, I edited them in Inkscape … Aren't those icons used as default avatar in user manager? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, mic

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Can you fix the files for inkscape? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel,

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. Hmm. The shadows no longer work correctly in Inkscape, but they work fine in the Qt SVG renderer, which is unusual since usually the Qt SVG renderer is the picky one. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm not sure if we actually use these anywhere, but the patch looks good to me. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL https

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Rocket Aaron
rocka updated this revision to Diff 77814. rocka added a comment. remove svg metadata REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28094?vs=77811&id=77814 BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL https://phabricator.kd

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Rocket Aaron
rocka edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Rocket Aaron
rocka edited the test plan for this revision. rocka added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Rocket Aaron
rocka created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rocka requested review of this revision. REVISION SUMMARY When executing `kdialog --geticon`, some errors would shown: $ kdialog --geticon qt.svg: /usr/share/icons/breeze-