D28112: Expose application menu via KWindowInfo
broulik added inline comments. INLINE COMMENTS > kwindowinfo.h:579 > + * > + * Requires NET::WMPid passed as properties parameter to the constructor. > + * Copy paste error, requires `NET::WM2ApplicationMenuServiceName` > kwindowinfo.h:588 > + * > + * Requires NET::WMPid passed as properties parameter to the constructor. > + * Copy paste error > netwm.h:1622 > +/** > + * @returns The menu service name of the window's application if present. > + * @since 5.69 application menu, or just menu? > netwm.h:1628 > +/** > + * @returns The menu object path of the window's application if present. > + * @since 5.69 application menu, or just menu? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28112: Expose application menu via KWindowInfo
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH appmenu-x11 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28112: Expose application menu via KWindowInfo
This revision was automatically updated to reflect the committed changes. Closed by commit R278:93814b513d45: Expose application menu via KWindowInfo (authored by cblack). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77921&id=77922 REVISION DETAIL https://phabricator.kde.org/D28112 AFFECTED FILES autotests/netwininfotestclient.cpp src/kwindowinfo.cpp src/kwindowinfo.h src/kwindowinfo_p.h src/netwm_def.h src/platforms/xcb/atoms_p.h src/platforms/xcb/kwindowinfo.cpp src/platforms/xcb/kwindowinfo_p_x11.h src/platforms/xcb/netwm.cpp src/platforms/xcb/netwm.h src/platforms/xcb/netwm_p.h To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28112: Expose application menu via KWindowInfo
cblack edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28112: Expose application menu via KWindowInfo
cblack retitled this revision from "[WIP] Expose application menu via KWindowInfo" to "Expose application menu via KWindowInfo". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
D28112: Expose application menu via KWindowInfo
cblack marked 2 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns