D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Kai Uwe Broulik 
broulik closed this revision.
broulik added a comment.


  https://phabricator.kde.org/R305:4caaf107f1d4f45ff28d0de1b7e7e541e5827e3a

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D28121

To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Harald Sitter 
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  Your `if(` style is now inconsistent with the `endif(`.
  Code LGTM

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D28121

To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  So it matches what `KNotification` is doing, especially since Phonon allows 
playing all sorts of files, which would then end up not being played when the 
notification is emitted.

TEST PLAN
  - Playback via canberra works, doesn't crash on teardown, multiple different 
sounds and playing the same sound repeatedly works
  - Playback via Phonon still works when canberra isn't found

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D28121

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/knotifyconfigactionswidget.cpp
  src/knotifyconfigactionswidget.h

To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns