D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f363a06ae697: Update window-pin, Add more sizes, Remove redundant edit-delete (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Nathaniel Graham
ngraham added a dependent revision: D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma, cblack, ngraha

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma, cblack, ngraham Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis added a comment. In D28228#633141 , @cblack wrote: > Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. eh, it's not. I guess I could do it in a separate patch. It's just a pain to u

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Carson Black
cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY 16 and 22px sizes added for window-pin and unpin. Style was also updated for window-