This revision was automatically updated to reflect the committed changes.
Closed by commit R236:11589f5e4166: [KFontChooser] More code cleanup (authored
by ahmadsamir).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28271?vs=78986&id=79812
REVISION DET
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
l-kfontchooser-3 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28271
To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel
ahmadsamir added a comment.
Ping.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D28271
To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 78986.
ahmadsamir added a comment.
Move family checkbox and listview code next to each other
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28271?vs=78983&id=78986
BRANCH
l-kfontchooser-3 (branched from mas
ahmadsamir updated this revision to Diff 78983.
ahmadsamir added a comment.
- Simplify connect() calls
- Move the connect() calls of the various checkboxes, in ShowDifferences
mode, after the widgets they enable/disable have been created
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST
ahmadsamir planned changes to this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D28271
To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
ngraham added a dependent revision: D28274: [KFontChooser] Add a checkbox to
toggle showing only monospaced fonts.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D28271
To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, c
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, cfeck, apol, bport.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
- Simplfy the layout by removing the splitter, the goal was to allow resizing
the font preview
