D28349: Fix Warnings

iasensio added a comment. In D28349#638395 , @bruns wrote: > @iasensio - are you using NFS? It's a NTFS partition using `fuseblk`, but anyway D28457 fixes the crash REPOSITORY R244 KCoreAddons

D28349: Fix Warnings

meven added inline comments. INLINE COMMENTS > bruns wrote in kdirwatch.cpp:946 > m_nfsPreferredMethod defaults to `KDirWatch::FAM`, i.e. it will crash below > now on NFS when FAM is disabled. So either change the default, or add a Q_FALLTHROUH() ? REPOSITORY R244 KCoreAddons REVISION

D28349: Fix Warnings

bruns added a comment. @iasensio - are you using NFS? INLINE COMMENTS > kdirwatch.cpp:946 > if (KFileSystemType::fileSystemType(e->path) == > KFileSystemType::Nfs) { > preferredMethod = m_nfsPreferredMethod; > } m_nfsPreferredMethod defaults to

D28349: Fix Warnings

iasensio added a comment. I seemed to reach the unreachable when I tried to open an external HDD on dolphin: https://bugs.kde.org/show_bug.cgi?id=419428 `ASSERT failure in Q_UNREACHABLE(): "Q_UNREACHABLE was reached", file /home/isma/kde/src/kcoreaddons/src/lib/io/kdirwatch.cpp, line

D28349: Fix Warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fcdf263339b4: Fix Warnings (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78655=78656 REVISION DETAIL

D28349: Fix Warnings

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28349 To: meven, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28349: Fix Warnings

meven updated this revision to Diff 78655. meven added a comment. Add an argc value check REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28349?vs=78654=78655 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28349 AFFECTED FILES

D28349: Fix Warnings

davidedmundson added inline comments. INLINE COMMENTS > kprocesstest_helper.cpp:17 > { > +Q_UNUSED(argc) > KProcess p; If we use argv[1] we very much should be using argc beforehand REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28349 To: meven,

D28349: Fix Warnings

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY We had 10 compile warnings before. 0 after REPOSITORY R244 KCoreAddons BRANCH