D28421: Add static method to check start condition

davidedmundson added a comment. That was embarrassing, I shouldn't try and rush. Sorry. Thanks for cleaning up after me. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson, broulik, dfaure, kossebau Cc: kde-frameworks-devel,

D28421: Add static method to check start condition

kossebau added inline comments. INLINE COMMENTS > hchain wrote in kautostart.h:289 > I think you added it to the wrong method ;) Fixed with 79fea5fc4043be72f3addf8980d4d78ef04530ff REPOSITORY R309 KService REVISION

D28421: Add static method to check start condition

hchain added inline comments. INLINE COMMENTS > davidedmundson wrote in kautostart.h:289 > Added. > https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 I think you added it to the wrong method ;) REPOSITORY R309 KService REVISION DETAIL

D28421: Add static method to check start condition

davidedmundson added inline comments. INLINE COMMENTS > dfaure wrote in kautostart.h:289 > This is new public API, it's missing @since 5.69 Added. https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 REPOSITORY R309 KService REVISION DETAIL

D28421: Add static method to check start condition

dfaure added inline comments. INLINE COMMENTS > kautostart.h:289 > + */ > +static bool isStartConditionMet(const QString ); > + This is new public API, it's missing @since 5.69 REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson,

D28421: Add static method to check start condition

This revision was automatically updated to reflect the committed changes. Closed by commit R309:fe5c63b177a1: Add static method to check start condition (authored by hchain). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78864=78870 REVISION

D28421: Add static method to check start condition

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson, broulik, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28421: Add static method to check start condition

hchain retitled this revision from "Add a new standalone executable to replace X-KDE-Autostart-Condition" to "Add static method to check start condition". hchain edited the summary of this revision. hchain edited the test plan for this revision. REPOSITORY R309 KService REVISION DETAIL

D28421: Add static method to check start condition

hchain updated this revision to Diff 78864. hchain added a comment. void REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28421?vs=78863=78864 REVISION DETAIL https://phabricator.kde.org/D28421 AFFECTED FILES src/services/kautostart.cpp