D28498: [xdgoutput] Explicitly set version of server interface

2020-05-01 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. All these problems go away with KWaylandServer \o/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498 To: davidedmundson, #kwin Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel,

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-14 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.h:281-288 > /** > * Creates the XdgOutputManagerInterface > * > * @return the created manager > * @since 5.47 > + * @deprecated use the version that takes a version > */ Please use

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-03 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in display.h:297 > You can't introduce another createXdgOutputManager() because it's not > overloaded. You probably need to rename this method, e.g. > createXdgOutputManager2. As you've pasted, it is BC, which is what

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-03 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > apol wrote in display.h:296 > Passing an enum as const& is wrong although it doesn't make much of a > difference in practice. > > `You can't introduce another createXdgOutputManager() because it's not > overloaded`. He's adding an overload, I

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in display.h:296 > I can't make it explicit. It's not a constructor Passing an enum as const& is wrong although it doesn't make much of a difference in practice. `You can't introduce another createXdgOutputManager() because

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > display.h:297 > + */ > +XdgOutputManagerInterface *createXdgOutputManager(const > XdgOutputInterfaceVersion , QObject *parent = nullptr); > + You can't introduce another createXdgOutputManager() because it's not overloaded. You probably

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in display.h:296 > I agree it's weird to take a const&, but it's what the others do I can't make it explicit. It's not a constructor REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread David Edmundson
davidedmundson updated this revision to Diff 79127. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28498?vs=79102=79127 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28498 AFFECTED FILES

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread David Edmundson
davidedmundson marked an inline comment as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in display.h:287 > Should we deprecate the one without version? I'll add a doc. I don't want to waste time with the macro stuff given we know there's only one user. >

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > display.h:296 > + */ > +XdgOutputManagerInterface *createXdgOutputManager(const > XdgOutputInterfaceVersion , QObject *parent = nullptr); > + explicit, also take enum class by value. REPOSITORY R127 KWayland REVISION DETAIL

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread Aleix Pol Gonzalez
apol added a comment. Some concerns at the documentation level. Looks good overall. INLINE COMMENTS > display.h:287 > */ > XdgOutputManagerInterface *createXdgOutputManager(QObject *parent = > nullptr); > Should we deprecate the one without version? >

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-02 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Implication being that when v2 is used name and description will