D28499: [LauncherJobs] Emit description

2020-05-04 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:692d9bc81f00: [LauncherJobs] Emit description (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28499?vs=79700&id=81849#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28499?vs=79700&id=81849

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28499: [LauncherJobs] Emit description

2020-04-21 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28499: [LauncherJobs] Emit description

2020-04-21 Thread Kai Uwe Broulik 
broulik added a comment.


  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28499: [LauncherJobs] Emit description

2020-04-09 Thread Nathaniel Graham 
ngraham added a comment.


  Seems sensible and sane to me. +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28499: [LauncherJobs] Emit description

2020-04-09 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 79700.
broulik added a comment.


  - Drop ellipsis

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28499?vs=79105&id=79700

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28499: [LauncherJobs] Emit description

2020-04-03 Thread Kai Uwe Broulik 
broulik added a comment.


  Given we don't add elippsis after any other KIO Job (e.g. "Copying") probably 
shouldn't do it here either?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28499: [LauncherJobs] Emit description

2020-04-02 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Provides for better error reporting.

TEST PLAN
  Can't go in before tagging due to string freeze
  F825: Screenshot_20200402_101736.png 

  
  I kinda think `KNotificationJobUiDelegate` should add a "Failed" of sorts to 
the title since it doesn't go through the regular kuiserver job tracking which 
does that in case of an error

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28499

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp
  src/gui/commandlauncherjob.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns