D2854: New: ECMAddQch, for generating qch & doxygen tag files

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c837f58d505b: New: ECMAddQch, for generating qch & doxygen tag files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2854?vs=14672=15148#toc REPOSITORY R240 Extra

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau added a comment. If there are no further comments or other feedback, I would like to commit this once 5.35 is tagged. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk,

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14672. kossebau added a comment. fix lett old "since 5.30" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14671=14672 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14671. kossebau added a comment. Restricted Application added projects: Frameworks, Build System. Some minor improvements, prepare for release with 5.36 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

ltoscano added a reviewer: KDE Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks, #kde_buildsystem Cc: shumski, kfunk,

[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8863. kossebau added a comment. lowercase virtual folder name for consistency with the Qt ones REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8856=8863 BRANCH addApiDox REVISION DETAIL

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz,

[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8856. kossebau added a comment. support inheriting LINK_QCHS, drop LINK_QCHS_VERSIONED for now REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8783=8856 BRANCH addApiDox REVISION DETAIL

[Differential] [Commented On] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember > KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if > CMAKE_INSTALL_PREFIX was /usr. > > Ok, so the

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz,

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau retitled this revision from "New: ECMAddQCH, for generating qch & doxygen tag files" to "New: ECMAddQch, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REPOSITORY R240 Extra CMake Modules

[Differential] [Updated, 1,178 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8783. kossebau added a comment. s/QCH/Qch/, use find_oackage for needed tools, more control over output REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8639=8783 BRANCH addApiDox REVISION DETAIL

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Fear I am still missing what you mean. So let's go explicitely, here is what > I understand to happen: > > There are six different cases when using this macro and on the first > invocation of cmake,

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > It is :) But with this latest revision it is not when that var is off =) I'm > saying that for both cases it should happen. Fear I am still missing what you mean. So let's go explicitely, here is what

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as > well? > At least this is how I understand >

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Right. But if you install a framework to same prefix as Qt, you get free > recognition of plugins, qml imports, etc... This is valid for both /usr and > custom prefix installs. > I guess what i want

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I mean, addition of qch subdir is 'your' invention here. > If Frameworks were to use only qmake build-system, i'm sure qch files would > end up in QT_INSTALL_DOCS directory. > I.e. for

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla > Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS > ... Not sure what you mean, please point out

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Not sure what you mean, please point out the issue you see here with more > details :) > > The plan here is: > if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS, > if not,

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8639. kossebau added a comment. adapt also documentation to doc/QCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8635=8639 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:534 > +else() > +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH" > +"documentation bundles in QCH format for Qt-extending libraries") I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's.

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8635. kossebau added a comment. Use rather subfolder doc/QCH for installing QCH files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8586=8635 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8586. kossebau added a comment. integrate feedback from review with use for kdb, kproperty & kreport CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8485=8586 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added dependent revisions: D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH. REVISION DETAIL

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek,

[Differential] [Updated, 1,059 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8485. kossebau added a comment. Add QTQCHDIR and QCHDIR to KDEInstallDirs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8364=8485 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added a comment. In https://phabricator.kde.org/D2854#64179, @shumski wrote: > > a) recommended install path for qch and tag files? > > At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. Good proposal, I think

[Differential] [Updated, 1,039 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8364. kossebau updated the test plan for this revision. kossebau added a comment. Small fixes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8348=8364 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added a comment. > a) recommended install path for qch and tag files? At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau retitled this revision from "New: ECMGenerateApiDox, for generating qch & tag files" to "New: ECMAddQCH, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. kossebau added a reviewer: Frameworks.