D2854: New: ECMAddQch, for generating qch & doxygen tag files
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c837f58d505b: New: ECMAddQch, for generating qch & doxygen tag files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2854?vs=14672=15148#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14672=15148 REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml tests/CMakeLists.txt tests/KDEInstallDirsTest/var_list.cmake To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau added a comment. If there are no further comments or other feedback, I would like to commit this once 5.35 is tagged. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated this revision to Diff 14672. kossebau added a comment. fix lett old "since 5.30" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14671=14672 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated this revision to Diff 14671. kossebau added a comment. Restricted Application added projects: Frameworks, Build System. Some minor improvements, prepare for release with 5.36 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8863=14671 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files
ltoscano added a reviewer: KDE Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks, #kde_buildsystem Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8863. kossebau added a comment. lowercase virtual folder name for consistency with the Qt ones REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8856=8863 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,239 lines] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8856. kossebau added a comment. support inheriting LINK_QCHS, drop LINK_QCHS_VERSIONED for now REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8783=8856 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau added inline comments.
INLINE COMMENTS
> shumski wrote in KDEInstallDirs.cmake:534
> Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember
> KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if
> CMAKE_INSTALL_PREFIX was /usr.
>
> Ok, so the non-recognition part should not happen that often -> I'm assuming
> qch files are looked up as QLibraryInfo::DocumentationPath (so,
> QT_INSTALL_DOCS) + *qch.
>
> So with your path, they will not be found (yeah with different prefix they
> aren0t still found, but with qch/ subdir user needs one additional envar for
> KF5 qch's - imagine you need to export QT_PLUGIN_PATH for Qt plugins, and one
> more path for KF5 plugins).
> I don't see a reason to append qch subdir to installation location -> as if
> you're intentionally hiding those files ;-)
Any chance you perhaps misread the code? Because what you say does not match
what should happen at least by what I intended by the code (and what it does on
testing) :)
The qch/ subdir is used with the non-QT_INSTALL_DOCS installation directory. So
`_define_relative(QTQCHDIR DATAROOTDIR "doc/qch")` would be e.g.
"/usr/share/doc/qch" when installing to prefix /usr. Both this and
"/usr/share/doc" will never result in Qt Assistant automatically adding the QCH
file to the default help file collection. This only happens when installing
directly into QT_INSTALL_DOCS (undocumented feature, but stable for some time
:) ).
In the branch which sets up QTQCHDIR to be the Qt system dir,
`_define_absolute(QTQCHDIR ${qt_docs_dir})` will result in QTQCHDIR being equal
to QT_INSTALL_DOCS. No /qch subdir here.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D2854
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, staniek, #frameworks
Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files
kossebau retitled this revision from "New: ECMAddQCH, for generating qch & doxygen tag files" to "New: ECMAddQch, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,178 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8783. kossebau added a comment. s/QCH/Qch/, use find_oackage for needed tools, more control over output REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8639=8783 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Fear I am still missing what you mean. So let's go explicitely, here is what > I understand to happen: > > There are six different cases when using this macro and on the first > invocation of cmake, from the combinations of installing to a different > prefix or the same prefix as Qt (2 variants) versus > KDE_INSTALL_USE_QT_SYS_PATHS being not set/defined, set to ON, set to OFF (3 > variants). > > In these 3 cases plugins, QCH & Co. will be all installed to Qt system dirs > and thus automatically picked up by Qt, without the need for further env var > settings: > > - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, different prefix > - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, same prefix > - KDE_INSTALL_USE_QT_SYS_PATHS not passed as argument, same prefix (so > > In the three other cases plugins, QCH & Co will be installed in dirs and need > further env var settings, for Qt (and Qt Assistant) to also pick up the stuff. > > Where do we see things differently? And just to make sure, you have seen the > right lines at the link I passed before, how > _default_KDE_INSTALL_USE_QT_SYS_PATHS is set to ON if the same prefix is used? Hm, i guess i haven't checked KDEInstallDirs in a while. Somehow i remember KDE_INSTALL_USE_QT_SYS_PATHS was only activated by default if CMAKE_INSTALL_PREFIX was /usr. Ok, so the non-recognition part should not happen that often -> I'm assuming qch files are looked up as QLibraryInfo::DocumentationPath (so, QT_INSTALL_DOCS) + *qch. So with your path, they will not be found (yeah with different prefix they aren0t still found, but with qch/ subdir user needs one additional envar for KF5 qch's - imagine you need to export QT_PLUGIN_PATH for Qt plugins, and one more path for KF5 plugins). I don't see a reason to append qch subdir to installation location -> as if you're intentionally hiding those files ;-) REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > It is :) But with this latest revision it is not when that var is off =) I'm > saying that for both cases it should happen. Fear I am still missing what you mean. So let's go explicitely, here is what I understand to happen: There are six different cases when using this macro and on the first invocation of cmake, from the combinations of installing to a different prefix or the same prefix as Qt (2 variants) versus KDE_INSTALL_USE_QT_SYS_PATHS being not set/defined, set to ON, set to OFF (3 variants). In these 3 cases plugins, QCH & Co. will be all installed to Qt system dirs and thus automatically picked up by Qt, without the need for further env var settings: - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, different prefix - -DKDE_INSTALL_USE_QT_SYS_PATHS=ON, same prefix - KDE_INSTALL_USE_QT_SYS_PATHS not passed as argument, same prefix (so In the three other cases plugins, QCH & Co will be installed in dirs and need further env var settings, for Qt (and Qt Assistant) to also pick up the stuff. Where do we see things differently? And just to make sure, you have seen the right lines at the link I passed before, how _default_KDE_INSTALL_USE_QT_SYS_PATHS is set to ON if the same prefix is used? REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as > well? > At least this is how I understand > https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n442 > to work. > This is also what I rely on, as I agree that it should also happen when > installing to the same prefix :) It is :) But with this latest revision it is not when that var is off =) I'm saying that for both cases it should happen. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Right. But if you install a framework to same prefix as Qt, you get free > recognition of plugins, qml imports, etc... This is valid for both /usr and > custom prefix installs. > I guess what i want to say is that there is IMHO no reason this should also > not work for QCH docs. But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as well? At least this is how I understand https://cgit.kde.org/extra-cmake-modules.git/tree/kde-modules/KDEInstallDirs.cmake#n442 to work. This is also what I rely on, as I agree that it should also happen when installing to the same prefix :) REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I mean, addition of qch subdir is 'your' invention here. > If Frameworks were to use only qmake build-system, i'm sure qch files would > end up in QT_INSTALL_DOCS directory. > I.e. for KDE_INSTALL_USE_QT_SYS_PATHS=ON the paths are Qt's, so are with > KDE_INSTALL_USE_QT_SYS_PATHS=OFF, just that for the latter case they are read > from sources, opposed to querying qmake. But that is the same for the current QTPLUGINDIR, QTQUICKIMPORTSDIR, & QMLDIR, no? They also only get set to the Qt system paths if KDE_INSTALL_USE_QT_SYS_PATHS=ON, otherwise get set to something based on general LIBDIR. (I would have liked to put the setting of QTQCHDIR next to these other ones, but at that time DATAROOTDIR is not yet defined, so had to create a separate if-else) And especially if installing multiple versions of the same dir (e.g. for different projects or as developer of the lib), it will be needed to optionally not install into the Qt system path, but point all the tools via ENV variables or other ways to the matching plugins or documentation. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla > Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS > ... Not sure what you mean, please point out the issue you see here with more details :) The plan here is: if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS, if not, some "normal" dir (there is no standard dir for QCH in general currently, everybody installs their 3rd-party QCH files somewhere). See thread http://lists.qt-project.org/pipermail/development/2016-November/027856.html and especially the latest http://lists.qt-project.org/pipermail/development/2016-November/028001.html Feedback is very welcome. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Not sure what you mean, please point out the issue you see here with more > details :) > > The plan here is: > if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS, > if not, some "normal" dir (there is no standard dir for QCH in general > currently, everybody installs their 3rd-party QCH files somewhere). > See thread > http://lists.qt-project.org/pipermail/development/2016-November/027856.html > and especially the latest > http://lists.qt-project.org/pipermail/development/2016-November/028001.html > Feedback is very welcome. I mean, addition of qch subdir is 'your' invention here. If Frameworks were to use only qmake build-system, i'm sure qch files would end up in QT_INSTALL_DOCS directory. I.e. for KDE_INSTALL_USE_QT_SYS_PATHS=ON the paths are Qt's, so are with KDE_INSTALL_USE_QT_SYS_PATHS=OFF, just that for the latter case they are read from sources, opposed to querying qmake. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8639. kossebau added a comment. adapt also documentation to doc/QCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8635=8639 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES kde-modules/KDEInstallDirs.cmake modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:534 > +else() > +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH" > +"documentation bundles in QCH format for Qt-extending libraries") I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS ... REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8635. kossebau added a comment. Use rather subfolder doc/QCH for installing QCH files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8586=8635 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES kde-modules/KDEInstallDirs.cmake modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8586. kossebau added a comment. integrate feedback from review with use for kdb, kproperty & kreport CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8485=8586 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES kde-modules/KDEInstallDirs.cmake modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added dependent revisions: D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH, D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,059 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8485. kossebau added a comment. Add QTQCHDIR and QCHDIR to KDEInstallDirs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8364=8485 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES kde-modules/KDEInstallDirs.cmake modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau added a comment. In https://phabricator.kde.org/D2854#64179, @shumski wrote: > > a) recommended install path for qch and tag files? > > At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. Good proposal, I think I should go for that for now. Because installing to QT_INSTALL_DOCS would solve the issue of discoverability, as e.g. Qt Assistant automatically picks up QCH files added there. IMHO if someone installs a package with a QCH file (especially for a Qt-based lib), it should be automatically included by the doc viewers and not need the user to also manually having to add it manually by searching the file in the system folders frst (so opt-out instead of opt-in). REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 1,039 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8364. kossebau updated the test plan for this revision. kossebau added a comment. Small fixes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8348=8364 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
shumski added a comment. > a) recommended install path for qch and tag files? At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau retitled this revision from "New: ECMGenerateApiDox, for generating qch & tag files" to "New: ECMAddQCH, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. kossebau added a reviewer: Frameworks. kossebau removed a subscriber: Frameworks. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: kfunk, staniek, winterz, ochurlaud, #kdevelop
