D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-05 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D28577

To: dfaure, vkrause, aacid, cgiboudeaux, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-05 Thread Volker Krause
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28577

To: dfaure, vkrause, aacid, cgiboudeaux, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

2020-04-04 Thread David Faure
dfaure created this revision.
dfaure added reviewers: vkrause, aacid, cgiboudeaux, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  There's nothing specific to ReadOnlyPart about the statusbar extension.
  This allows to port KMailPart to KParts::Part and still have it show
  items in the kontact statusbar.
  
  Technically the overloaded ctor could be ambiguous (e.g. if called with
  a nullptr argument), but such an arg wouldn't make sense, and I built
  all of the git.kde.org modules that use StatusBarExtension, without
  issues.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28577

AFFECTED FILES
  src/statusbarextension.cpp
  src/statusbarextension.h

To: dfaure, vkrause, aacid, cgiboudeaux, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns