D28606: Add iconSize property to PC2 ToolButton

ndavis abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28606: Add iconSize property to PC2 ToolButton

mart added a comment. I don't think we should put any new feature in plasmacomponents2. it will be removed in qt6 anyways and work should be more concentrated to a) port away from it altogether abd b) if the pc3 version doesn't work, put effort in fixing that REPOSITORY R242 Plasma Framew

D28606: Add iconSize property to PC2 ToolButton

davidedmundson added a comment. > He said he wouldn't accept patches that do that for notifications or KRunner because of the issues with PC3 I doubt that's what was meant. There have definitely been some bad patches that blindly ported to PC3 without adequate testing. That's highly

D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. In D28606#642513 , @ngraham wrote: > Darn. Maybe we should fix the PC3 tooltips though? :) Maybe, but I don't know what that would entail. For more context: I asked Kai about porting notifications to PC3 so that I

D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. In D28606#642514 , @ngraham wrote: > Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) This doesn't actually affect toolbutton sizing, just icon sizing. Although, if you ma

D28606: Add iconSize property to PC2 ToolButton

ngraham added a reviewer: mart. ngraham added a comment. Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: broulik, ngraha

D28606: Add iconSize property to PC2 ToolButton

ngraham added a comment. Darn. Maybe we should fix the PC3 tooltips though? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28606: Add iconSize property to PC2 ToolButton

ndavis added a subscriber: broulik. ndavis added a comment. In D28606#642509 , @ngraham wrote: > If the developer has these needs, why not port to the PC3 version, which has this feature already? @broulik said we can't do that for some th

D28606: Add iconSize property to PC2 ToolButton

ngraham added a comment. If the developer has these needs, why not port to the PC3 version, which has this feature already? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: ngraham, kde-frameworks-devel, LeGast00n, cbl

D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. I'm getting a binding loop: : QML QQuickLayoutAttached: Binding loop detected for property "minimumWidth" I'm guessing that's `Layout.minimumWidth` inside the `ToolButtonStyle` `IconItem` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabri

D28606: Add iconSize property to PC2 ToolButton

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

ndavis retitled this revision from "Add iconSize to PC2 ToolButton" to "Add iconSize property to PC2 ToolButton". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ng