D28682: rename and export done signal in filecontentindexer
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. thx REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D28682: rename and export done signal in filecontentindexer
astippich marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D28682: rename and export done signal in filecontentindexer
astippich updated this revision to Diff 79904. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79751&id=79904 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES src/file/filecontentindexer.cpp src/file/filecontentindexer.h src/file/fileindexscheduler.cpp To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D28682: rename and export done signal in filecontentindexer
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> filecontentindexer.cpp:111
> [this, elapsed, batchSize] { newBatchTime(elapsed,
> batchSize); },
> Qt::QueuedConnection);
> }
Sorry, seems I got a little bit confused, the `commitedBatch` has to go here.
And when I look at it, you can piggy-back on `newBatchTime`, which is emitted
on each batch. For your use case, just ignore the values.
So new proposal, rename `newBatchTime(elapsed, batchSize)` to
`committedBatch(elapsed, batchSize)` and export it. Keep `done` as is.
> filecontentindexer.cpp:114
> }
> -QMetaObject::invokeMethod(this, &FileContentIndexer::done,
> Qt::QueuedConnection);
> +QMetaObject::invokeMethod(this, &FileContentIndexer::committedBatch,
> Qt::QueuedConnection);
> }
This has to stay as is, as it means **everything**done
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D28682
To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
D28682: rename and export done signal in filecontentindexer
astippich retitled this revision from "export done signal in filecontentindexer" to "rename and export done signal in filecontentindexer". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
