D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carson Black 
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether 
(authored by cblack).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28712?vs=79738&id=79769

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carl Schwan 
ognarb accepted this revision.
ognarb added a comment.


  LGTM

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Olivier Churlaud 
ochurlaud added a comment.


  In D28712#645095 , @ognarb wrote:
  
  > Not tested yet but I like the style :) Though to be more consistent with 
the style used in other KDE websites, I would change the background color to 
#fff and use #f8f9fa for the sidebar.
  >
  > I also saw some alignment issues with the method args:
  >
  > F8227657: image.png 
  >
  > I will give a more in-depth review tomorrow.
  
  
  The issues already exist in the current design. I would do a second change 
request for fixing those issues (there are more if you browse a little in 
complex methods) and already push this cosmetic only patch.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Olivier Churlaud 
ochurlaud accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Olivier Churlaud 
ochurlaud added a comment.


  Nice work. This is a ship it for me!

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Nathaniel Graham 
ngraham added a comment.


  Dang that looks way nicer.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan 
ognarb added a comment.


  Not tested yet but I like the style :) Though to be more consistent with the 
style used in other KDE websites, I would change the background color to #fff 
and use #f8f9fa for the sidebar.
  
  I also saw some alignment issues with the method args:
  
  F8227657: image.png 
  
  I will give a more in-depth review tomorrow.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carl Schwan 
ognarb added a reviewer: ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carson Black 
cblack created this revision.
cblack added reviewers: VDG, ognarb.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  F8227629: image.png  F8227630: 
image.png  F8227631: image.png 

  
  F8227633: _home_cdblack_workdir_kirigamidocs_build_index.html(Pixel 2 XL) 
(1).png  F8227634: 
_home_cdblack_workdir_kirigamidocs_build_kwindowsystem_html_classKWindowSystem.html(Pixel
 2 XL).png 

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna