D28755: Breeze Icons cannot be built from read-only source location

[Pino Toscano]

pino added a comment.


  Fixed with def21bf6c691a40bef233efd898fcb7ff57d55bb 
, 
thanks for the notice.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

To: marten, #breeze, ngraham
Cc: bcooksley, ngraham, pino, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28755: Breeze Icons cannot be built from read-only source location

[Ben Cooksley]

bcooksley added a comment.


  This does not build on the CI system - please see 
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/
 amongst others.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

To: marten, #breeze, ngraham
Cc: bcooksley, ngraham, pino, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28755: Breeze Icons cannot be built from read-only source location

[Jonathan Marten]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0a5dd2972b62: Allow building from a read-only source 
location (authored by marten).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28755?vs=79867=80219

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze, ngraham
Cc: ngraham, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28755: Breeze Icons cannot be built from read-only source location

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice improvement.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

To: marten, #breeze, ngraham
Cc: ngraham, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28755: Breeze Icons cannot be built from read-only source location

[Jonathan Marten]

marten updated this revision to Diff 79867.
marten added a comment.


  Yes, that would mean fewer changes to the validate_svg.sh script.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28755?vs=79845=79867

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28755: Breeze Icons cannot be built from read-only source location

[Pino Toscano]

pino added a comment.


  Or maybe the other way round:
  
  - add an optional parameter to the script to specify the source directory, 
defaulting to "."
  - run the script in the build directory, passing the source directory as 
parameter

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

To: marten, #breeze
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28755: Breeze Icons cannot be built from read-only source location

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marten requested review of this revision.

REVISION SUMMARY
  In the situation, for example, where a master source tree may be shared among 
a number of build systems via NFS (each build system needs its own writeable 
build directory, of course).  However, building the Breeze icons needs write 
access to the source tree for the SVG validation check, which is run in 
CMAKE_CURRENT_SOURCE_DIR:
  
  [100%] Validating SVG
  breezeicons/validate_svg.sh: line 3: xmlerrors: Read-only file system
  rm: cannot remove 'xmlerrors': No such file or directory
  make[2]: *** [CMakeFiles/breeze-validate-svg.dir/build.make:58: 
CMakeFiles/breeze-validate-svg] Error 1
  make[1]: *** [CMakeFiles/Makefile2:231: 
CMakeFiles/breeze-validate-svg.dir/all] Error 2
  make: *** [Makefile:130: all] Error 2
  
  This change writes the temporary XML error file to CMAKE_CURRENT_BINARY_DIR, 
which can be relied on to be writeable.

TEST PLAN
  Build Breeze Icons with this change, observed that the SVG validation check 
completes with no 'read-only file system' errors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28755

AFFECTED FILES
  CMakeLists.txt
  validate_svg.sh

To: marten, #breeze
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns