D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-13 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:340e1ac7c38f: [FstabWatcher] Use static QStringLiteral 
instead of macro (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28778?vs=79990=79992

REVISION DETAIL
  https://phabricator.kde.org/D28778

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-13 Thread Stefan Brüns 
bruns updated this revision to Diff 79990.
bruns added a comment.


  move statics into namespace

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28778?vs=79949=79990

REVISION DETAIL
  https://phabricator.kde.org/D28778

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D28778#646791 , @broulik wrote:
  
  > Don't use global statics in library code
  
  
  in case it gets statically compiled?

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Kai Uwe Broulik 
broulik added a comment.


  Don't use global statics in library code

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks, apol
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Stefan Brüns 
bruns added a dependent revision: D28779: [Fstab] Use new style connect API.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28778

To: bruns, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

2020-04-12 Thread Stefan Brüns 
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QFilesystemWatcher::addPath takes a QString as argument, so avoid
  construction of tempary QString on each call.
  
  This also avoids a name clash between the Solid::Backends::Fstab::FSTAB
  logging category and the FSTAB macro.

TEST PLAN
  no functional changes

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28778

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabwatcher.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns