D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham added a dependent revision: D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham added a comment. I pondered that myself but every app needs to implement its own behavior, and we're not even consistent about making this a toggle action vs two separate actions. That alone is probably a good reason to make a standard action, though. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
elvisangelaccio added a comment. Does it make sense to also create a standard action in kconfigwidgets? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
elvisangelaccio added a comment. > and F8 seems kind of random. I was asking myself why F8 was chosen and yes, it looks like it was totally random: https://github.com/KDE/kdelibs/commit/8e26f7410a9280b504d97cdfbe5d3568cfa7b9d4 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
This revision was automatically updated to reflect the committed changes. Closed by commit R237:65cc12ab3ec8: Add standard shortcut for Show/Hide Hidden Files (authored by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28802?vs=80039=80049 REVISION DETAIL https://phabricator.kde.org/D28802 AFFECTED FILES src/gui/kstandardshortcut.cpp src/gui/kstandardshortcut.h To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH add-show-hide-hidden-files-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham added a dependent revision: D28803: [KDirOperator] Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham added a dependent revision: D28804: Use new "Show/Hide Hidden Files" standard shortcut. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28802 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D28802: Add standard shortcut for "Show/Hide Hidden Files"
ngraham created this revision. ngraham added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Add a standard shortcut for this action so it can be synchronized between different apps and the file dialog; see https://bugs.kde.org/show_bug.cgi?id=262551. The action in Dolphin also has F8 bound to this, but the definition here only accept two default shortcuts, and F8 seems kind of random. CCBUG: 262551 TEST PLAN Apply to KIO and C to Dolphin and test there REPOSITORY R237 KConfig BRANCH add-show-hide-hidden-files-shortcut (branched from master) REVISION DETAIL https://phabricator.kde.org/D28802 AFFECTED FILES src/gui/kstandardshortcut.cpp src/gui/kstandardshortcut.h To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
