D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:52c0a136f9ff: [ExpandableListItem] make it touch-friendly 
(authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80218&id=80445

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham added a comment.


  Good question. I'm not sure it's possible here; the list views that use this 
component as a delegate might have to learn how to unset the selection with 
their own `TapHandler`. I'm not 100% sure on that though.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a comment.


  This generically works, except for: would it be possible to make it so that 
clicking on an empty point will drop the list and button hover status? 
otherwise, you kind of get stuck to this situation:
  F8242311: Screenshot_20200416_224831.png 

  
  (ps yay, first time I actually manage to try a patch and review it. I'm 
getting better!)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Niccolò Venerandi]

niccolove added a reviewer: niccolove.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham updated this revision to Diff 80218.
ngraham added a comment.


  Simpler enabled handling

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80217&id=80218

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham updated this revision to Diff 80217.
ngraham added a comment.


  Use TapHandler instead of MultiPointTouchArea

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80054&id=80217

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28808

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28808: [ExpandableListItem] make it touch-friendly

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, apol, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use a MultiPointTouchHandler as the top-level item to handle touch input. We 
still need
  a MouseArea inside it to handle non-touch hover and right-click behaviors.
  
  FEATURE: 393749
  FIXED-IN: 5.70

TEST PLAN
  Click behavior is identical to how it was before, but now touch works too: 
F8234452: 20200413_150741-smaller-30.mp4 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  make-ExpandableListItem-touchable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns