D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bd502bf0af46: [Extractor] Remove IdleStateMonitor wrapper 
class (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28862?vs=80295=80298

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns 
bruns updated this revision to Diff 80295.
bruns added a comment.


  add line break before closing brace in lambda, use 2 minutes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28862?vs=80236=80295

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> broulik wrote in app.cpp:63
> Coding style

Side note - both the Frameworks and the reference Qt coding style say nothing 
about lambdas.

If you read the `connect(...);` as a single statement, it should stay as is.

If you read the lambda as a function, the closing brace should go on a separate 
line.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns 
bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns 
bruns added a comment.


  In D28862#649411 , @broulik wrote:
  
  > It used to be 2 minutes, now it's 1?
  
  
  It used to be infinity ... 1 minute is completely sufficient.

INLINE COMMENTS

> broulik wrote in app.cpp:59
> Why the member variable? It's a singleton after all

Because its used recurrently in a slot in a later patch

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Kai Uwe Broulik 
broulik added a comment.


  It used to be 2 minutes, now it's 1?

INLINE COMMENTS

> app.cpp:59
> +static int s_idleTimeout = 1000 * 60; // 1 min
> +m_idleTime = KIdleTime::instance();
> +m_idleTime->addIdleTimeout(s_idleTimeout);

Why the member variable? It's a singleton after all

> app.cpp:63
> +qCInfo(BALOO) << "Busy, paced indexing";
> +m_isBusy = true; });
> +connect(m_idleTime, QOverload::of(::timeoutReached), 
> this, [this] (int /*identifier*/) {

Coding style

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-15 Thread Stefan Brüns 
bruns added a dependent revision: D28863: [Extractor] Fix idle monitoring.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-15 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  IdleStateMonitor is just a wrapper around KIdleTime, which can be
  implemented in a few lines inline.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28862

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/idlestatemonitor.cpp
  src/file/extractor/idlestatemonitor.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams