D28953: [Extractor] Fix progress reporting

2020-04-19 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:273b7a1d7a63: [Extractor] Fix progress reporting 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28953?vs=80486&id=80572

REVISION DETAIL
  https://phabricator.kde.org/D28953

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham, mlaurent, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D28953: [Extractor] Fix progress reporting

2020-04-19 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28953

To: bruns, #baloo, ngraham, mlaurent, apol
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D28953: [Extractor] Fix progress reporting

2020-04-18 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, ngraham, mlaurent.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Commit 125b4db3230b 
 
("Port endl to \n or std::cout/cerr as in qt5.15 endl
  is Qt:: namespaced") removed the implicit "endl" flush. As a result,
  the startedIndexing and finishedIndexing signals would be issued at the
  same time.
  
  This is especially bad when indexing large files, as both the KInfoCenter
  qml component and `balooctl monitor` would report the previous file (or
  no file at all, if only a single file is changed).

TEST PLAN
  start kinfocenter / balooctl monitor
  touch some huge PDF files

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28953

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams