D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes.
Closed by commit R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to 
QProcess (authored by broulik).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29062?vs=80785=80973

REVISION DETAIL
  https://phabricator.kde.org/D29062

AFFECTED FILES
  src/kded.cpp

To: broulik, davidedmundson, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-21 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kded.cpp:67
>  
>  static void runKonfUpdate()
>  {

The function has a typo, should be `runKConfUpdate`, no?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29062

To: broulik, davidedmundson, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29062: Port KToolInvocation::kdeinitExecWait to QProcess

2020-04-21 Thread Kai Uwe Broulik
broulik created this revision.
broulik added reviewers: davidedmundson, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Part of T12185 
  Verified it's calling it and returning with `NormalExit` and `0` exitcode - 
didn't actually test whether it worked :D

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29062

AFFECTED FILES
  src/kded.cpp

To: broulik, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns