D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
kossebau added a comment. The failure which triggered this patch is that appstreamcli or one of the things it links to (since recently?) wants to use some gsettings stuff, which it tries to look up in the system via XDG_DATA_DIRS, as found by sitter. See https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/96/testReport/projectroot/autotests/testpackage_appstream/ The old code tried to still make any existing XDG_DATA_DIRS content used, just in a broken way. Which this patch fixes. Or: I do not take further responsibilities :P If that setup is broken/questionable by design, could be possible, did not investigate that, leaving to the actual kpackage maintainers/experts. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
pino added a comment. (Commented in the wrong place) Shouldn't the test completely ignore the system location, to avoid interferences from the system installation? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
This revision was automatically updated to reflect the committed changes. Closed by commit R290:bb560f8dfa0a: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended (authored by kossebau). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29063?vs=80787=80840 REVISION DETAIL https://phabricator.kde.org/D29063 AFFECTED FILES autotests/CMakeLists.txt To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks like an improvement REPOSITORY R290 KPackage BRANCH fixXDG_DATA_DIRSextending REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
sitter added a comment. Looks reasonable. @apol thoughts? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
kossebau added a comment. Small disadvantage of the current code is that this binds things to the value of XDG_DATA_DIRS at "cmake" runtime, not "make test" runtime. That would need the move of the env var setting into kpackagetoolappstreamtest.cmake I guess. Tell if you think that is important. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended
kossebau created this revision. kossebau added reviewers: Frameworks, mart, apol, sitter, bcooksley. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Setting XDG_DATA_DIRS in the ENVIRONMENT property using "XDG_DATA_DIRS=/path:$XDG_DATA_DIRS" has two flaws - the value string is not evaluated e.g. by a shell but set directly, so $XDG_DATA_DIRS will stay verbatim - if XDG_DATA_DIRS was not set before, setting it now will trigger the rules to use the default /usr/local/share & /usr/share only if XDG_DATA_DIRS is not set, thus effectively removing these dirs now REPOSITORY R290 KPackage BRANCH fixXDG_DATA_DIRSextending REVISION DETAIL https://phabricator.kde.org/D29063 AFFECTED FILES autotests/CMakeLists.txt To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
