D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-23 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:ee827d8efba2: [NetworkManager-qt] Replace foreach with 
range for, hopefully last pass (authored by ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80880=80961

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-23 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir 
ahmadsamir added a comment.


  Depends on D29091 .

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29093

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

2020-04-22 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 80880.
ahmadsamir retitled this revision from "[NetworkManager-qt] Replace foreach 
with range for" to "[NetworkManager-qt] Replace foreach with range for, 
hopefully last pass".
ahmadsamir edited the summary of this revision.
ahmadsamir removed 1 blocking reviewer(s): jgrulich.
ahmadsamir added a comment.
Herald added 1 blocking reviewer(s): jgrulich.


  Verbatim

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80879=80880

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 80879.
ahmadsamir added a comment.


  Get the last ones

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80877=80879

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for

2020-04-22 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns