D29102: Prefer QIcon::pixmap(QWindow*, ...) overload
This revision was automatically updated to reflect the committed changes. Closed by commit R242:25ce2b90dab1: Prefer QIcon::pixmap(QWindow*, ...) overload (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29102?vs=80908&id=80945 REVISION DETAIL https://phabricator.kde.org/D29102 AFFECTED FILES src/declarativeimports/core/iconitem.cpp src/declarativeimports/core/windowthumbnail.cpp To: apol, #plasma, #frameworks, davidedmundson Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D29102: Prefer QIcon::pixmap(QWindow*, ...) overload
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yeah, size is in logical pixels. Multiplying doesn't make sense. I'm sure more high DPI bugs are caused by clients trying to be clever. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29102 To: apol, #plasma, #frameworks, davidedmundson Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D29102: Prefer QIcon::pixmap(QWindow*, ...) overload
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It takes into account the dpi of the screen we're rendering to. Other overloads assume the window is nullptr and will use the primary screen's dpi which can change almost randomly. TEST PLAN Icons still look fine even if I drag windows from a screen to another. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29102 AFFECTED FILES src/declarativeimports/core/iconitem.cpp src/declarativeimports/core/windowthumbnail.cpp To: apol, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
