D29121: Replace foreach with range-for

2020-04-23 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:b53859b89a13: Replace foreach with range-for (authored by 
ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29121?vs=80963=80965

REVISION DETAIL
  https://phabricator.kde.org/D29121

AFFECTED FILES
  src/settings/ipv4setting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29121: Replace foreach with range-for

2020-04-23 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29121

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29121: Replace foreach with range-for

2020-04-23 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  I missed one file before, now it should actually build with -DQT_NO_FOREACH.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29121

AFFECTED FILES
  src/settings/ipv4setting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns