dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29206
To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir accepted this revision.
ahmadsamir added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dfaure wrote in kprocessrunner.cpp:55
> I see what you're saying.
>
> It's the name of the spec, though.
> https://specifications.freedesktop.org/desktop-entry-
dfaure added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in kprocessrunner.cpp:55
> IMHO, the word "entry" here is confusing, the first thing that comes to mind
> is that an entry (i.e. a line) in the file is invalid.
I see what you're saying.
It's the name of the spec, though.
https:/
ahmadsamir added a comment.
Otherwise makes sense.
INLINE COMMENTS
> kprocessrunner.cpp:55
> +if (!service->isValid()) {
> +emitDelayedError(i18n("The desktop entry file\n%1\nis not valid.",
> service->entryPath()));
> +return;
IMHO, the word "entry" here is confusing, t
dfaure updated this revision to Diff 81281.
dfaure retitled this revision from "Move check for invalid service from
KDesktopFileActions to ApplicationLauncherJobTest" to "Move check for invalid
service from KDesktopFileActions to ApplicationLauncherJob".
dfaure added a comment.
fix wrong "Tes
